feat(source param): Call macro with additional source parameter #70
Conversation
|
Gotcha. Makes sense. Could you update docs as well? |
|
Oh, and the snapshots are failing, those will need an update 👍 Thanks! |
|
Sure, most of tests are failing on my machine though and I dont know why yet (IMHO they shouldnt). This is not a priority to me so it will have to wait some time before I get back to it - I definitely will get back to it though... eventually 😉 |
|
Actually instead of fixing the issues on my machine I just fixed failing test based on CI report 😅 It is now failing on something different and it seems unrelated to my PR, could you take a look (maybe you'd have some insight on what might be going wrong)? |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 77 77
Branches 18 18
=====================================
Hits 77 77
Continue to review full report at Codecov.
|
.eslintcache
Outdated
| @@ -1 +0,0 @@ | |||
| {"/Users/mateuszburzynski/Desktop/babel-plugin-macros/src/__tests__/index.js":{"size":7797,"mtime":1531302441000,"hashOfConfig":"19k0y1k","results":{"filePath":"/Users/mateuszburzynski/Desktop/babel-plugin-macros/src/__tests__/index.js","messages":[],"errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0}}} | |||
There was a problem hiding this comment.
lol, havent noticed that I've committed this
|
Thanks for taking care of this. I should have looked into diff on GitHub - would've noticed then that I've accidentally made those mistakes >.< |
Useful for relative macro paths - when I want to convert a macro import to sibling, regular, file.