Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Newer TypeScript Versions #136

Closed
davidinoa opened this issue Dec 15, 2023 · 2 comments · Fixed by #137
Closed

Support for Newer TypeScript Versions #136

davidinoa opened this issue Dec 15, 2023 · 2 comments · Fixed by #137
Labels

Comments

@davidinoa
Copy link

davidinoa commented Dec 15, 2023

Feature Request

Summary:

This issue is a proposal to add support for newer versions of TypeScript (e.g., 5.x)

Background:

Currently, eslint-config-kentcdodds specifies TypeScript ^4.0.0 as a peer dependency. Projects using newer TypeScript versions may encounter compatibility issues with the current version of eslint-config-kentcdodds.

Proposal:

I propose updating the peerDependencies in the package.json to include TypeScript 5.x versions. This update would allow users of eslint-config-kentcdodds to take advantage of the latest TypeScript features while ensuring compatibility and linting effectiveness.

Potential Challenges:

Ensuring that the existing rules and configurations are compatible with TypeScript 5.x.

Benefits:

  • Keeps eslint-config-kentcdodds up-to-date with the latest TypeScript developments.
  • Expands the user base by supporting projects that have upgraded to TypeScript 5.x.
  • Improves developer experience for those using the latest TypeScript features.

Suggested Implementation:

Update the peerDependencies in package.json to include "typescript": ">=4.0.0 <6.0.0" (or a more appropriate version range).

If necessary, review and update configurations and rules to ensure compatibility with TypeScript 5.x.

Looking Forward:

I am willing to help implement this feature and address any potential challenges. I look forward to hearing the community's input and guidance on this proposal.

@kentcdodds
Copy link
Owner

I'm definitely open to a pull request, but I don't use this config myself much anymore so it's hard to justify spending time working on it.

Dattaya added a commit to Dattaya/eslint-config-kentcdodds that referenced this issue Dec 26, 2023
Copy link

github-actions bot commented Jan 3, 2024

🎉 This issue has been resolved in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants