Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it worth adding *.ts and *tsx to jest.config.js #25

Closed
mateuscb opened this issue Dec 31, 2017 · 2 comments
Closed

Is it worth adding *.ts and *tsx to jest.config.js #25

mateuscb opened this issue Dec 31, 2017 · 2 comments

Comments

@mateuscb
Copy link
Contributor

  • kcd-scripts version: 0.27.2
  • node version: 9.3.0
  • yarn version: 1.3.2

Relevant code or config

  collectCoverageFrom: ['src/**/*.js'],
  testMatch: ['**/__tests__/**/*.js'],
  testPathIgnorePatterns: [...ignores],
  coveragePathIgnorePatterns: [...ignores, 'src/(umd|cjs|esm)-entry.js$'],
  transformIgnorePatterns: ['[/\\\\]node_modules[/\\\\].+\\.(js|jsx)$'],

Problem description: This isn't a huge problem since the benefit of kcd-scripts is the ability to overwrite options. But, given the high number of typescript, it would be nice to not have to overwrite the same options every time.

Suggested solution: Before creating a PR, I wanted to pose the question to see what others thought. Is addin *.ts and *.jsx to jest.config.js a worthy thought?

@kentcdodds
Copy link
Owner

Hi @mateuscb!

I prefer flow, but I can understand why others might want to have improved typescript support. I definitely do not plan on including typescript specific scripts etc., but for simple things like this where it doesn't make the codebase much more complex, I'm ok to accept a PR for it.

Thanks :)

@mateuscb
Copy link
Contributor Author

mateuscb commented Jan 3, 2018

Hi @kentcdodds!

Cool, OK I'll work on a PR for that. Thanks!

@mateuscb mateuscb closed this as completed Jan 6, 2018
layershifter pushed a commit to layershifter/kcd-scripts that referenced this issue Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants