Added Typescript to the jest config #26
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 67.06% 67.06%
=======================================
Files 22 22
Lines 337 337
Branches 80 80
=======================================
Hits 226 226
Misses 83 83
Partials 28 28
Continue to review full report at Codecov.
|
| @@ -102,6 +102,11 @@ Or, for `jest`: | |||
| const {jest: jestConfig} = require('kcd-scripts/config') | |||
| module.exports = Object.assign(jestConfig, { | |||
| // your overrides here | |||
|
|
|||
| // for test written in Typescript, add: | |||
There was a problem hiding this comment.
Since kcd-scripts won't work out of the box for Typescript tests because I felt the transform was too specific to put into kcd-script; I thought it would be nice to document what was needed to do so. What do you think?
| @@ -102,6 +102,11 @@ Or, for `jest`: | |||
| const {jest: jestConfig} = require('kcd-scripts/config') | |||
| module.exports = Object.assign(jestConfig, { | |||
| // your overrides here | |||
|
|
|||
| // for test written in Typescript, add: | |||
src/config/jest.config.js
Outdated
| collectCoverageFrom: ['src/**/*.js'], | ||
| testMatch: ['**/__tests__/**/*.js'], | ||
| moduleFileExtensions: ['js', 'jsx', 'json', 'ts', 'tsx'], | ||
| collectCoverageFrom: ['src/**/*.js', 'src/**/*.js'], |
There was a problem hiding this comment.
Should this be:
collectCoverageFrom: ['src/**/*.+(js|jsx|ts|tsx)'],
There was a problem hiding this comment.
Also a good question. I got this from a couple projects I work on, which came from else where, and not sure why jsx wasn't added. Will get to the bottom of this. Thanks!
src/config/jest.config.js
Outdated
| testMatch: ['**/__tests__/**/*.js'], | ||
| moduleFileExtensions: ['js', 'jsx', 'json', 'ts', 'tsx'], | ||
| collectCoverageFrom: ['src/**/*.js', 'src/**/*.js'], | ||
| testRegex: '/__tests__/.*\\.(ts|tsx|js)$', |
There was a problem hiding this comment.
Could this be:
testMatch: ['**/__tests__/**/*.+(js|jsx|ts|tsx)'],
There was a problem hiding this comment.
Interesting, I will test this. For some reason I thought testRegex had to be used for regex, and testMatch only accepted list of type. But I'll test and verify.
|
@kentcdodds I didn't understand that those values accepted glob patterns. That makes a lot more sense. Thanks for catching that! |
|
Thanks! :) |
|
Thank you! :) |
The value of content should not be converted based on the flow direction of the document, as it will usually not be the intended result since `right` is not the RLT equvalent of `left` in the context of `content`. The equvalent of `left` would be `اليسار` or `يسار` in Arabic and `שמאל` or `שמאלה` in Hebrew.
What:
This PR addresses issue #25
The idea was to minor Typescript options to the jest config so tests written typescript of projects using
kcd-scriptsdon't have to overwrite too much.Unfortunately, one still needs to add the given transform. I felt this would have been too specific to add to
kcd-scriptssrc, but added it to the readme so it makes it a bit easier for new-comers usingkcd-scriptswith typescript.Why:
Makes it easier when using
kcd-scriptsin Typescripts projectHow:
Added Typescript file extensions to the jest config
Checklist: