Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format does not recognize all prettier config formats. #96

Closed
schaab opened this issue Oct 4, 2019 · 2 comments · Fixed by #97
Closed

format does not recognize all prettier config formats. #96

schaab opened this issue Oct 4, 2019 · 2 comments · Fixed by #97
Labels

Comments

@schaab
Copy link
Contributor

schaab commented Oct 4, 2019

  • kcd-scripts version: 1.8.0
  • node version: 10.16.3
  • npm (or yarn) version: 6.11.3

Relevant code or config

# .prettierrc.toml
semi = true
singleQuote = false

What you did:

Added a local .prettierrc.toml and ran format.

What happened:

The local configuration was not respected.

Reproduction repository

Problem description: I have a local .prettierrc.toml and it is not being respected.

Suggested solution: Prettier uses cosmiconfig for configuration file support. Leverage cosmiconfig when looking for local configuration. It also handles inspecting package.json as well. I suspect you could leverage this with all the different commands eliminating the need to do the search yourself.

@schaab
Copy link
Contributor Author

schaab commented Oct 4, 2019

#97 fixes this

@kentcdodds
Copy link
Owner

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants