Fix/locate all prettier configs #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Oct 4, 2019
| @@ -168,12 +169,20 @@ function writeExtraEntry(name, {cjs, esm}, clean = true) { | |||
| ) | |||
| } | |||
|
|
|||
| function hasLocalConfig(moduleName, searchOptions = {}) { | |||
There was a problem hiding this comment.
doesn't prettier have a function for finding config? Maybe we should use that instead?
There was a problem hiding this comment.
Yes, it does.
I was thinking that this eventually this could be used for the other commands as well.
|
@all-contributors please add @schaab for code and tests |
|
I've put up a pull request to add @schaab! 🎉 |
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
What:
The
formatcommand does not recognize all local configuration file typesWhy:
The docs state that the tool will respect a local configuration for a tool and use that over the default.
How:
Leverage
cosmiconfigto search for any type of local configuration.Prettieruses it for config file support. This allows us to look for a module name rather than maintaining a list of files types to look for.Checklist: