Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stripDiacritics capabilities #8

Closed
kentcdodds opened this issue Aug 29, 2016 · 2 comments
Closed

Add stripDiacritics capabilities #8

kentcdodds opened this issue Aug 29, 2016 · 2 comments
Labels
enhancement help wanted

Comments

@kentcdodds
Copy link
Owner

Basically open source this (cc @JedWatson) and add it as a dependency to match-sorter.

I personally think that this should be enabled by default. Thoughts?

Also, I'm going to work on making it possible to have multiple files right now with our build so we can have dependencies.
kentcdodds pushed a commit that referenced this issue Aug 29, 2016
feat(match): ignore diacritics when matching by default
8e9cf5d 
It's reasonable to consider this change breaking, but I think that it's
unlikely that anyone is depending on what I would consider a bug.

This adds our first dependency. Everything seems to be working with
bundledDependencies (tested locally) and the UMD builds.

Closes #8
@kentcdodds kentcdodds mentioned this issue Aug 29, 2016
Merged
@rogeliog
Copy link
Collaborator

I'm happy to help on this one 😄

@kentcdodds
Copy link
Owner Author

Actually I've already implemented it, but could you review it for me? #10

kentcdodds pushed a commit that referenced this issue Aug 30, 2016
feat(match): ignore diacritics when matching by default
76041bc 
It's reasonable to consider this change breaking, but I think that it's
unlikely that anyone is depending on what I would consider a bug.

This adds our first dependency. Everything seems to be working with
bundledDependencies (tested locally) and the UMD builds.

Closes #8
kentcdodds pushed a commit that referenced this issue Aug 30, 2016
feat(match): ignore diacritics when matching by default (#10)
774ca9c 
It's reasonable to consider this change breaking, but I think that it's
unlikely that anyone is depending on what I would consider a bug.

This adds our first dependency. Everything seems to be working with
bundledDependencies (tested locally) and the UMD builds.

Closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogeliog @kentcdodds