Additions #26
Open
Additions #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with custom application objects.
… on it instead of the concrete interface. Added a quick bit mask selection option in addition to the selected items array. The cancelDelegate should include the current Selector (maybe should deprecate the old one and promote the new one as required). Created a helper class to allow using blocks as the delegate to the selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a good component, thanks for sharing!
I needed some tweaks and fixes for my use case, and hope it might be useful for the library or anyone using it:
• Doesn't require FB on the Demo - only request authorization in the FB tab
• Uncoupled Items based on a protocol instead of requiring a strict item class (allow for showing arbitrary model objects directly, either by implementing the protocol in your class or in a category)
• Delegate block helper if one wants to move away from delegation pattern
• Some typos & warnings fixed