Derecommend use of dztest

kentnl · Sep 10, 2016 · fa37013 · fa37013
1 parent 56ba202
commit fa37013
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -3,6 +3,7 @@ Release history for Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes
 {{$NEXT}}
  [Checks]
  - Derecommend use of ConfigDumper, it was a nice idea, but the dependency and test complexity I can do without.
+ - Derecommend use of dztest, again, nice idea, but unwanted complexity proliferation.
 
  [Dependencies::Stats]
  - Dependencies changed since 0.005001, see misc/*.deps* for details

diff --git a/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm b/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm
@@ -499,10 +499,10 @@ sub dzil_plugin_check {
 FIND_DZTEST: {
     for my $tfile ( @{ $self->tfiles } ) {
       if ( $assert->test( have_line => $tfile, qr/dztest/ ) ) {
+        $self->log('Tests should probably not use dztest (Dist::Zilla::Util::Test::KENTNL)');
         last FIND_DZTEST;
       }
     }
-    $self->log('A test should probably use dztest (Dist::Zilla::Util::Test::KENTNL)');
   }
   return;
 }