Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semicolon at start #2524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

octavioamu
Copy link

A good practice when working with multiple JS files is to add a single semicolon at the very beginning of each file to terminate any preceding malformed logic.

A good practice when working with multiple JS files is to add a single semicolon at the very beginning of each file to terminate any preceding malformed logic.
Copy link

@danieltj27 danieltj27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea considering this file will be concatenated into a minified js file with other scripts. No harm in doing this.

@octavioamu
Copy link
Author

Thanks buddy

On Oct 5, 2016 7:22 AM, "Daniel James" notifications@github.com wrote:

@danieltj27 approved this pull request.

Probably a good idea considering this file will be concatenated into a
minified js file with other scripts. No harm in doing this.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2524 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABS5DRki0CgTu6fBwOjv9gMcQr-P2U8nks5qw3pegaJpZM4KDer7
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants