Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets sample: Button page #68

Merged
merged 48 commits into from
May 28, 2022
Merged

Widgets sample: Button page #68

merged 48 commits into from
May 28, 2022

Conversation

kenz-gelsoft
Copy link
Owner

@kenz-gelsoft kenz-gelsoft commented May 20, 2022 •
edited
Loading

Implement the Button page's basic behaviors which is part of the wx's widgets sample.

Some TODO's will be resolved in another PR.

  • Generate new wx Classes bindings
    • wxTextEntry
      • Mixed-in wxTextCtrl manually
    • wxItemContainerImmutable
      • Mixed-in wxRadioBox manually
    • wxIcon
    • wxBitmapButton
  • Add and fixed some Builder pattern construtors
    • Add wx::BitmapButton builder
    • Fix constructor default styles for classes
  • Add and expand wx generic wxList bindings
    • wxSizerItem
  • Support following param types
    • wxDirection -> c_int
  • Fix existing binding bugs
    • wx-returns non-ASCII string was cut off
  • Support Additional Event types
    • (wx)EVT_CHECKBOX -> wx::RustEvent::CheckBox
    • (wx)EVT_RADIOBOX -> wx::RustEvent::RadioBox

kenz-gelsoft and others added 18 commits May 22, 2022 11:21
@kenz-gelsoft
WIP: Working on button page
426151b 
* link error on wx3.0 environment
@kenz-gelsoft
Fix wx3.0 build error
ee97a97
@kenz-gelsoft
Generate wxTextEntry class
65bc92f
@kenz-gelsoft
WIP: Implementing Button page (2)
a5255fa
@kenz-gelsoft
Fix wx3.0 build error
2e2b3c4
@kenz-gelsoft
WIP: start showing button options
6781cf2
@kenz-gelsoft
Fix some default styles for builders
3a40f0a
@kenz-gelsoft
Copy minimal for textentry test code
57f9ef6
@kenz-gelsoft
Make small testcase which calls wxTextEntry method on wxTextCtrl
d7a5025
@kenz-gelsoft
Workaround wxTextEntry crash by calling their method through derived …
f16a09b 
…class pointer

* we need saner mechanism to do this.
@kenz-gelsoft
Revert "Workaround wxTextEntry crash by calling their method through …
375a016 
…derived class pointer"

This reverts commit f16a09b.
@kenz-gelsoft
Fix wxTextEntry maunally
5ca91f8
@kenz-gelsoft
Manually mix-in wxTextEntry
fea7ad0
@kenz-gelsoft
Minor rename
f636ccd
@kenz-gelsoft
Revert "Make small testcase which calls wxTextEntry method on wxTextC…
8ff502c 
…trl"

This reverts commit d7a5025.
@kenz-gelsoft
Revert "Copy minimal for textentry test code"
ea02490 
This reverts commit 57f9ef6.
@kenz-gelsoft
Merge pull request #69 from kenz-gelsoft/workaround_bad_mixin_textentry
4874e0e 
Workaround bad mixin textentry
@kenz-gelsoft
Change button label
f6ff4f1 
* but doesn't work with non-latin chars
@kenz-gelsoft kenz-gelsoft changed the base branch from main to widgets_sample_before_button_page May 23, 2022 23:41
@kenz-gelsoft kenz-gelsoft changed the base branch from widgets_sample_before_button_page to main May 23, 2022 23:42
@kenz-gelsoft
Copy link
Owner Author

TODO: fix windows build.

@kenz-gelsoft kenz-gelsoft changed the title Widgets sample Widgets sample: Button page May 28, 2022
@kenz-gelsoft kenz-gelsoft marked this pull request as ready for review May 28, 2022 09:34
@kenz-gelsoft kenz-gelsoft merged commit e078d64 into main May 28, 2022
@kenz-gelsoft kenz-gelsoft deleted the widgets_sample branch May 28, 2022 09:35
@kenz-gelsoft
Copy link
Owner Author

part of #61

@kenz-gelsoft kenz-gelsoft mentioned this pull request May 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kenz-gelsoft