-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use binary crate #90
Use binary crate #90
Conversation
- `cargo:rustc-link-arg` was not transitive. - Specified it in project-base config.toml
* At least, ming64 treat this as rvalue, and retrieving the address of rvalue is error. * This fixes build error.
@ancwrd1 I think with this PR, you can use your vendored repo with And also it is able to use another binary crate by overriding concrete crates in consumer project's cargo configuration like: [dependencies]
wx-x86_64-pc-windows-gnu = { git = "another/git/repo" } This will support your suggested use case in #72? Any other feedbacks? (Better name or specification of feature is welcome!) Thanks in advance. |
Thanks for your work! I think the common feature name used by many popular crates is 'vendored' (or like 'vendored-wx', etc). For example it is used in native-tls, openssl, reqwest. But it's not too important. |
OK, to rename to that.
I'm afraid that it is not what you expected. The At first, I made this target specific dependency to test overriding dependency, But I don't remove this because this is convenient to test just if it's build or not. (I'll add GitHub Action for this in another PR.) It's not hard to copy corresponding DLLs from |
I've now added static manually built lean and mean MSVC repo as well: The following flags are needed for compilation: |
@ancwrd1 Thank you for providing static prebuilt crate. I'll utilize that when I'll start writing unit tests for windows in future. |
cargo build --features vendored
builds with prebiult repo's wx binary if specified for that target.doesn't link currentlyNow it builds and run locally with help from @ancwrd1.