Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the algorithms #288

Merged
merged 20 commits into from May 31, 2018
Merged

Reorganize the algorithms #288

merged 20 commits into from May 31, 2018

Conversation

danghai
Copy link
Collaborator

@danghai danghai commented May 29, 2018 •
edited

PR to reorganize the algorithms

@coveralls
Copy link

Pull Request Test Coverage Report for Build 277

  • 11 of 11 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 91.31%
Totals Coverage Status
Change from base Build 274: 0.07%
Covered Lines: 2669
Relevant Lines: 2923
💛 - Coveralls

goswami-rahul
goswami-rahul approved these changes May 30, 2018
View reviewed changes
Copy link
Collaborator

@goswami-rahul goswami-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danghai Awesome work! The API looks great now.
This PR is good to merge now to keon:reorg branch. Once all the reorganizing is complete, we will merge that branch (#286 ) to keon:master.

@keon keon merged commit ba01f41 into keon:reorg May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goswami-rahul goswami-rahul goswami-rahul approved these changes

@christianbender christianbender Awaiting requested review from christianbender

@keon keon Awaiting requested review from keon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danghai @coveralls @goswami-rahul @keon