Add a similar and maybe more understandable algorithm of generate_parenthesis #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 695
💛 - Coveralls |
| @@ -27,3 +27,17 @@ def add_pair(res, s, left, right): | |||
| res = [] | |||
| add_pair(res, "", n, 0) | |||
| return res | |||
|
|
|||
|
|
|||
| def generate_parenthesis_(n): | |||
There was a problem hiding this comment.
Please add tests in the tests folder (tests/test_backtrack.py).
Rename the new version as generate_parenthesis_v2(), also change the original version name to generate_parenthesis_v1().
There was a problem hiding this comment.
there are some problems, let me correct it and push it later.
christianbender
requested changes
Jul 29, 2018
| res.append(s) | ||
| if left > 0: | ||
| add_pair(res, s+"(", left-1, right) | ||
| if right > 0 && left<right: |
There was a problem hiding this comment.
Write and instead of &&
Merged
|
@RenliangShi Could you solve the problem in |
ghost
closed this
|
Hi @RenliangShi, why do you close the PR? You intend to create new PR for it? |
|
I have already made a PR for it. #384
Hai Hoang Dang <notifications@github.com> 于2018年8月1日周三 上午5:09写道：
… Hi @RenliangShi <https://github.com/RenliangShi>, why do you close the
PR? You intend to create new PR for it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#381 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AnRFTKf576CqXAS3ACec6a5gETlPdcAxks5uMMecgaJpZM4Vi2gV>
.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.