Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sort/radix_sort (#395) #397

Merged
merged 2 commits into from
Sep 4, 2018
Merged

fix sort/radix_sort (#395) #397

merged 2 commits into from
Sep 4, 2018

Conversation

InnoFang
Copy link
Contributor

@InnoFang InnoFang commented Sep 3, 2018

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?
  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
      Use position as a loop variable instead of is_done to fix the bug that isn't to be find easily.
    • Fixes #[issue number] if related to any issue
      bug report for radix sort #395
  • other

@coveralls
Copy link

coveralls commented Sep 3, 2018

Pull Request Test Coverage Report for Build 736

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 71.49%

Changes Missing Coverage Covered Lines Changed/Added Lines %
algorithms/sort/radix_sort.py 2 4 50.0%
Totals Coverage Status
Change from base Build 729: 0.01%
Covered Lines: 4303
Relevant Lines: 6019

💛 - Coveralls

Copy link
Owner

@keon keon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! I added one minor comment.


position *= 10
return arr
return arr
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could you add a new line at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@keon keon merged commit f5fec12 into keon:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants