Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added binomial coefficient calculator in algorithms/maths #704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added binomial coefficient calculator in algorithms/maths #704

wants to merge 1 commit into from

Conversation

DarkMoron
Copy link

No description provided.

@DarkMoron DarkMoron closed this Oct 1, 2020
@DarkMoron DarkMoron reopened this Oct 1, 2020
@ericklarac
Copy link
Collaborator

Could you add test cases?

@DarkMoron
Copy link
Author

DarkMoron commented Oct 1, 2020 •
edited

Could you add test cases?

They are already there at the end of the .py file.
image

@goswami-rahul
Copy link
Collaborator

A different version is already done at maths/combination.py. You can it as another function there. Also, don't perform any interaction (input, print) here, add the tests at tests/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DarkMoron @ericklarac @goswami-rahul