Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armstrong number is added. #710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Armstrong number is added. #710

wants to merge 2 commits into from

Conversation

Shyamashrita
Copy link

No description provided.

goswami-rahul
goswami-rahul requested changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@goswami-rahul goswami-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap it up in a function, and also explain what is an Armstrong number is.
Also add tests at tests/

@Shyamashrita
Copy link
Author

ok will surely make the required changes.

@Shyamashrita
Copy link
Author

why error is showing?

@Shyamashrita
Copy link
Author

Can you please tell me the failed check?

@Shyamashrita
Copy link
Author

I really need to get it merge for hacktoberfest. Please help me out.

@ericklarac
Copy link
Collaborator

@Shyamashrita The build keeps waiting for your input. Follow the contributing guidelines, add some tests for your code. You can review this PR as a guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goswami-rahul goswami-rahul goswami-rahul requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shyamashrita @ericklarac @goswami-rahul