New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary_linkedlist_to_Decimal #716
base: master
Are you sure you want to change the base?
Conversation
def __init__(self,data): | ||
self.data = data | ||
self.next = None | ||
#to create linkedlist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to pep8, there should be two empty lines between classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some test cases? Take this PR as a guide
@@ -188,6 +188,7 @@ If you want to uninstall algorithms, it is as simple as: | |||
- [swap_in_pairs](algorithms/linkedlist/swap_in_pairs.py) | |||
- [is_sorted](algorithms/linkedlist/is_sorted.py) | |||
- [remove_range](algorithms/linkedlist/remove_range.py) | |||
- [binary_linkedlist_to_decimal](algorithms/linkedlist/binaryToDecimal.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename the file using snake case
def __init__(self): | ||
self.head = None | ||
|
||
def getDecimal(self,head): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use snake case naming convention
No description provided.