Create num_perfect_squares.py #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this file also fixes the issue #769, please review and provide a feedback |
|
@rashidkalwar Add test cases, please |
ericklarac
requested changes
Aug 10, 2021
|
|
||
| i=1 | ||
|
|
||
| #Now just chekc for 2 if not 2 return 3 |
| @@ -0,0 +1,37 @@ | |||
| """ | |||
| Some examples: | |||
There was a problem hiding this comment.
Add and algorithm description, also add proper test cases
|
just added all the changes as requested please check and merge if all ok. |
ericklarac
reviewed
Aug 10, 2021
There was a problem hiding this comment.
Add test cases please, you can see examples of test cases on this PR
| @@ -1,16 +1,20 @@ | |||
| """ | |||
| This Algorithm takes a Integer as a parameter and returns the least number of perfect square numbers that sum upto it. | |||
Added test cases.
|
@ericklarac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an algorithm that calculates the least amount of perfect squares that are required to sum a given number fixes #767