Polonomial division #840
Open
Polonomial division #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves outstanding TODO. It turns out to be quite hard to actually define division of polynomials containing more than one variable in a satisfying manner. It is possible to defining a basis to use (for example, by sorting monomials in a lexicographic order) but this will require further work.
expands on functionality to polynomial/polynomial TODO. Test that assert ValueError for multiple variable divisor polynomials have only been commented out and might need an update instead.
Uses a Gröbner-basis in order to generalize euclidean division to polynomials with multiple variables. Co-authored-by: Mark <mantaur@users.noreply.github.com>
…l-division-expanded feat: expand polynomial division
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #839.
Division is implemented using euclidean division (aka. long division) and generalized to polynomials with multiple variables using a Gröbner-basis. The choice of basis was made by a loose recommendation in this article.