Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types derived from built-in types (i.e. str, int, float) do not serialize correctly #98

Closed
keotl opened this issue Dec 22, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@keotl
Copy link
Owner

keotl commented Dec 22, 2019

In this example, serializing the Player class yields an incorrect response.

@Serializable
class Player(object):
    player_id: PlayerIdentifier

class PlayerIdentifier(str):
    pass

Actual

{
    "player": {}
}

Expected

{
    "player": "my_player_id"
}
@keotl keotl added the bug Something isn't working label Dec 22, 2019
keotl added a commit that referenced this issue Dec 22, 2019
* Addresses #98
* fix derived type serialization

* deserialize into type derived from built-in type

* simpler subclass test

* fix builtin type check on typing hint error
@keotl keotl closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant