-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update keplergl-jupyter bindings #1572
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
26acd67
parent d7afdd622627c339fd8b3927616251f5df525554
lixun910 f438ccd
update documentation for keplergl-jupyter upgrade
lixun910 ab0b6f7
Add additional publish step for publishing kepler-jupyter to NPM
lixun910 5353437
update documentation
lixun910 52af6d3
fix node requirement: keplergl-jupyter-0.3.0 depends on kepler.gl@2.5…
lixun910 68219f5
fix typos in RELEASE.md
lixun910 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
name: Build KeplerGL Python Package | ||
|
||
on: push | ||
|
||
jobs: | ||
|
||
build_and_publish: | ||
runs-on: ubuntu-latest | ||
if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]')" | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Use Node.js 12.x | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 12.x | ||
|
||
- name: Set up Python 3.8 | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.8 | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install twine virtualenv | ||
|
||
- name: Build KeplerGL | ||
env: | ||
MapboxAccessTokenJupyter: ${{ secrets.MAPBOXTOKEN }} | ||
run: | | ||
python -m virtualenv venv | ||
source venv/bin/activate | ||
pip install jupyter jupyterlab jupyter-packaging | ||
cd bindings/kepler.gl-jupyter | ||
python setup.py sdist | ||
|
||
- name: Test KeplerGL | ||
run: | | ||
source venv/bin/activate | ||
pip install bindings/kepler.gl-jupyter/dist/*.tar.gz | ||
if [ ! -f "venv/share/jupyter/nbextensions/keplergl-jupyter/index.js" ]; then | ||
venv/bin/jupyter nbextension install --py --sys-prefix keplergl | ||
venv/bin/jupyter nbextension enable --py --sys-prefix keplergl | ||
fi | ||
venv/bin/jupyter nbconvert --execute bindings/kepler.gl-jupyter/notebooks/DataFrame.ipynb --to python | ||
python bindings/kepler.gl-jupyter/notebooks/DataFrame.py | ||
|
||
- name: Create artifact | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: keplergl-pypi | ||
path: bindings/kepler.gl-jupyter/dist/ | ||
|
||
- name: Publish Pypi | ||
lixun910 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if: github.event_name == 'release' && github.event.action == 'created' | ||
env: | ||
TWINE_USERNAME: __token__ | ||
TWINE_PASSWORD: ${{ secrets.npm_token }} | ||
run: | | ||
python -m twine upload bindings/kepler.gl-jupyter/dist/*.tar.gz | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
recursive-include keplergl/static *.* | ||
recursive-include keplergl-jupyter/labextension *.* | ||
include keplergl-jupyter.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[build-system] | ||
requires = ["jupyter_packaging~=0.7.0", "jupyterlab>=3.0.0,==3.*", "setuptools>=40.8.0", "wheel"] | ||
build-backend = "setuptools.build_meta" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be
on:push
oron:release
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be “on:push”, which means this action can be used to build, check and test keplergl python package on push with changes. For release and publish, there is a step: “-name: Check Release Tag”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, see the updated steps in “RELEASE.md” : https://github.com/lixun910/kepler.gl/blob/build-pypi-conda/bindings/kepler.gl-jupyter/RELEASE.md