Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update keplergl-jupyter bindings #1572

Merged
merged 6 commits into from Aug 29, 2021
Merged

Conversation

lixun910
Copy link
Collaborator

  1. Upgrade keplergl-jupyter widget for JupyterLab 3
  2. Add build script to build keplergl-jupyter for jupyterlab separately using @jupyter/builder
  3. Upgrade build script setup.py using jupyter_packaging library
  4. Add support to Google colab (no interaction with widget because of lacking colab support). New function show() was proposed:
from keplergl import KeplerGl
map1 = KeplerGl()
map1.show()

Others

  1. Add GitHub Actions “build-publish-pypi.yml” to build, test and publish (when tag release) keplergl python package to PyPI:
  2. Add condo-forge/keplergl-feedstock repo: https://github.com/lixun910/staged-recipes/tree/keplergl-feedstock (transfer to keplergl org later)
Note:
The source tarball of keplergl in PyPi will be used to build for conda-forge automatically.

Related issues:
#646
#1565 #882 #1565 #1165 #931

@lixun910
Copy link
Collaborator Author

@heshan0131 pull request is ready for review. Thanks!

@heshan0131
Copy link
Contributor

@heshan0131 pull request is ready for review. Thanks!

can you rebase your pr with master, it seems to contain the last PR on master

once you rebased your pr with master, you need to do a force push to remote branch

@lixun910 lixun910 force-pushed the build-pypi-conda branch 2 times, most recently from 9ecd861 to 8b41959 Compare August 13, 2021 22:14
author Xun Li <xunli@uchicago.edu> 1628282154 -0700
committer Xun Li <xunli@uchicago.edu> 1628888305 -0700

parent d7afdd6
author Xun Li <xunli@uchicago.edu> 1628282154 -0700
committer Xun Li <xunli@uchicago.edu> 1628888276 -0700

parent d7afdd6
author Xun Li <xunli@uchicago.edu> 1628282154 -0700
committer Xun Li <xunli@uchicago.edu> 1628888217 -0700

Create build-publish-pypi.yml

Add GitHub Actions to build and publish keplergl python package to PyPI

Update build-publish-pypi.yml

Add mapbox token secret
fix artifact path
fix condition to publish to pypi

Update build-publish-pypi.yml

fix path in upload-artifact and publish pypi

Update build-publish-pypi.yml

add Check KeplerGL Installation
add Test Notebook DataFrame.ipynb

Update build-publish-pypi.yml

update test KeplerGL

Update build-publish-pypi.yml

The keplergl-jupyter widget needs to be updated for JupyterLab 3 keplergl#882 keplergl#1565 keplergl#1165

Update build-publish-pypi.yml

add jupyter-packaging

Update build-publish-pypi.yml

add jupyter for jupyter labextension build

Update build-publish-pypi.yml

add jupyterlab

Add support to Google colab keplergl#931

Update build-publish-pypi.yml

fix path in upload-artifact and publish pypi

Signed-off-by: Xun Li <lixun910@gmail.com>

Update build-publish-pypi.yml

Signed-off-by: Xun Li <lixun910@gmail.com>

The keplergl-jupyter widget needs to be updated for JupyterLab 3 keplergl#882 keplergl#1565 keplergl#1165

Signed-off-by: Xun Li <lixun910@gmail.com>

Update build-publish-pypi.yml

add jupyterlab

Signed-off-by: Xun Li <lixun910@gmail.com>

Add support to Google colab keplergl#931

Signed-off-by: Xun Li <lixun910@gmail.com>

allow height option to work in google colab

Signed-off-by: Xun Li <lixun910@gmail.com>
@lixun910
Copy link
Collaborator Author

Got it. Thanks, @heshan0131 Just rebase my pr with master.

@heshan0131
Copy link
Contributor

Can you add to https://github.com/keplergl/kepler.gl/blob/master/docs/keplergl-jupyter/README.md

To describe:

  1. How to install kepler widget with condo-forge
  2. How to install and launch kepler widget in jupyter labs
  3. How to developed kepler widget in local jupyterlab env
  4. How to install kepler widget in Google colab...explain the limited interaction and use show

1. add "Installation -- Using conda"
2. add notes for install keplergl for jupyterlab3
3. add section to setup local dev env for jupyter notebook and jupyterlab
4. add section to use KeplerGL in google colab
5. add comments for show() function

Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
….4, therefore node version >= 12.0.0 should be expected.

update formats.

Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
@@ -0,0 +1,77 @@
name: Build KeplerGL Python and NPM Packages

on: push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be on:push or on:release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be “on:push”, which means this action can be used to build, check and test keplergl python package on push with changes. For release and publish, there is a step: “-name: Check Release Tag”.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heshan0131 heshan0131 merged commit 2f8b19f into keplergl:master Aug 29, 2021
@patrickbeekman
Copy link

@heshan0131 When will this be released into a new version for keplergl-jupyter?

@kyri-petrou
Copy link

Any update on when will this be released? Latest versions on pypi and conda-forge are still 0.3.0

phi-line pushed a commit to phi-line/kepler.gl that referenced this pull request Oct 21, 2022
… conda-forge (keplergl#1572)

1. Upgrade keplergl-jupyter widget for JupyterLab 3
2. Add build script to build keplergl-jupyter for jupyterlab separately using @jupyter/builder
3. Upgrade build script setup.py using jupyter_packaging library
4. Add support to Google colab (no interaction with widget because of lacking colab support). New function show() was proposed
5. Add GitHub Actions “build-publish-pypi.yml” to build, test and publish (when tag release) keplergl python package to PyPI:
6. Add condo-forge/keplergl-feedstock repo: https://github.com/lixun910/staged-recipes/tree/keplergl-feedstock (transfer to keplergl org later)

Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: kishan <phi.liney@gmail.com>
phi-line pushed a commit to phi-line/kepler.gl that referenced this pull request Oct 21, 2022
… conda-forge (keplergl#1572)

1. Upgrade keplergl-jupyter widget for JupyterLab 3
2. Add build script to build keplergl-jupyter for jupyterlab separately using @jupyter/builder
3. Upgrade build script setup.py using jupyter_packaging library
4. Add support to Google colab (no interaction with widget because of lacking colab support). New function show() was proposed
5. Add GitHub Actions “build-publish-pypi.yml” to build, test and publish (when tag release) keplergl python package to PyPI:
6. Add condo-forge/keplergl-feedstock repo: https://github.com/lixun910/staged-recipes/tree/keplergl-feedstock (transfer to keplergl org later)

Signed-off-by: Xun Li <lixun910@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants