[Chore]: Technical: Isolate cloud-providers #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariaterekhova-actionengine
changed the title
dariaterekhova-actionengine
force-pushed
the
dt/cloud-providers-isolation
branch
from
ec4826c
to
b6354fe
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
|
Make sure to fix import in |
heshan0131
approved these changes
Aug 23, 2022
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/cloud-providers-isolation
branch
from
b6354fe
to
ae9307c
Compare
heshan0131
reviewed
Aug 23, 2022
| @@ -25,7 +25,8 @@ import {UploadAnimation} from './status-panel'; | |||
| import ImageModalContainer from './image-modal-container'; | |||
There was a problem hiding this comment.
unrelated...but saw this duplicated import on line 25 & 27. it can be merged into one line
heshan0131
reviewed
Aug 23, 2022
| @@ -21,7 +21,7 @@ | |||
| import {OAuthApp} from '@carto/toolkit'; | |||
| import Console from 'global/console'; | |||
| import CartoIcon from './carto-icon'; | |||
| import {Provider} from 'kepler.gl/cloud-providers'; | |||
| import {Provider} from '@kepler.gl/cloud-providers'; | |||
| import {createDataContainer, formatCsv} from 'kepler.gl/reducers/table-utils'; | |||
There was a problem hiding this comment.
this line needs to be updated too? createDataContainer formatCsv has been moved
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/cloud-providers-isolation
branch
from
0162a23
to
0aee455
Compare
Signed-off-by: Daria Terekhova <daria.terekhova@actionengine.com>
dariaterekhova-actionengine
force-pushed
the
dt/cloud-providers-isolation
branch
from
0aee455
to
2db0565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.