Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: Technical: Isolate cloud-providers #1942

Merged
merged 4 commits into from
Aug 23, 2022
Merged

[Chore]: Technical: Isolate cloud-providers #1942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2a0f44
cloud-provider isolation
dariaterekhova-actionengine Aug 23, 2022
ae9307c
package.json update
dariaterekhova-actionengine Aug 23, 2022
46c8552
examples imports updated
dariaterekhova-actionengine Aug 23, 2022
2db0565
imports merge
dariaterekhova-actionengine Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 0 additions & 28 deletions src/cloud-providers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,34 +29,6 @@
"dist",
"umd"
],
"dependencies": {
"@deck.gl/geo-layers": "^8.4.11",
"@deck.gl/core": "^8.4.11",
"@deck.gl/extensions": "^8.4.11",
"@deck.gl/layers": "^8.4.11",
"@deck.gl/mesh-layers": "^8.4.11",
"@kepler.gl/deckgl-layers": "^2.5.5",
"@kepler.gl/layers": "^2.5.5",
"@kepler.gl/constants": "^2.5.5",
"@kepler.gl/types": "^2.5.5",
"@loaders.gl/core": "^2.3.12",
"@loaders.gl/gltf": "^2.3.12",
"@mapbox/geojson-normalize": "0.0.1",
"@turf/bbox": "^6.0.1",
"@types/geojson": "^7946.0.7",
"global": "^4.3.0",
"h3-js": "^3.1.0",
"keymirror": "^0.1.1",
"lodash.memoize": "^4.1.2",
"lodash.uniq": "^4.0.1",
"long": "^4.0.0",
"react": "^16.8.4",
"s2-geometry": "^1.2.10",
"styled-components": "^4.1.3",
"type-analyzer": "0.3.0",
"viewport-mercator-project": "^6.0.0",
"wellknown": "^0.5.0"
},
"nyc": {
"sourceMap": false,
"instrument": false
Expand Down
3 changes: 2 additions & 1 deletion src/components/modals/overwrite-map-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ import {UploadAnimation} from './status-panel';
import ImageModalContainer from './image-modal-container';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated...but saw this duplicated import on line 25 & 27. it can be merged into one line

import {FormattedMessage} from '@kepler.gl/localization';
import {ImageModalContainerProps} from './image-modal-container';
import { Provider } from '@kepler.gl/cloud-providers';
import {Provider} from '@kepler.gl/cloud-providers';
import {cleanupExportImage as cleanupExportImageAction} from 'actions';

/** @typedef {import('./overwrite-map-modal').OverwriteMapModalProps} OverwriteMapModalProps */

Expand Down