Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross compiling support for MSVC. #548

Merged
merged 2 commits into from
Jun 11, 2016

Conversation

xpol
Copy link
Contributor

@xpol xpol commented May 3, 2016

This is needed, when native compiler is not installed but cross compiler does.

See #534.

This is needed, when native compiler is not installed but cross compiler does.
@mpeterv
Copy link
Contributor

mpeterv commented May 3, 2016

Thank you @xpol! Haven't tested this yet but it looks good. By the way, is there a reason why install.bat is both a batch file and a Lua script? It messes up syntax highlighting a lot. Would it make more sense to move the Lua code into install.lua and call that from install.bat?

@mpeterv
Copy link
Contributor

mpeterv commented May 3, 2016

Tested, it works.

@xpol
Copy link
Contributor Author

xpol commented May 3, 2016

I just choose syntax manually.
I think it is good to separate bat and Lua. But I don't known how it works, I just update it.

@xpol
Copy link
Contributor Author

xpol commented May 3, 2016

i tested with vs2013.

@Tieske
Copy link
Contributor

Tieske commented May 3, 2016

By the way, is there a reason why install.bat is both a batch file and a Lua script?

The installer used to be a batch file, but it was very cumbersome and hard to maintain, so it was rewritten as a Lua file (by @ignacio). I for one would like to keep it this way, the repo is already dragging so much files along, keeping this in one file is a bigger benefit than the syntax highlighting imo.

@mpeterv
Copy link
Contributor

mpeterv commented May 14, 2016

@xpol I think we also need to ensure that these scripts that we now use directly exist for all VS versions, because unlike vcvarsall.bat their paths are not documented. Or, better, fall back to vcvarsall.bat if arch-specific scripts are not found.

@hishamhm
Copy link
Member

I want to make a new minor release. Windowsfolk, is this good for merging?

@xpol
Copy link
Contributor Author

xpol commented May 23, 2016

@mpeterv
commit 11b65a6 has fallback to documented vcvarsall.bat when the undocumented bats not found.

@mpeterv
Copy link
Contributor

mpeterv commented Jun 11, 2016

Tested this locally with some VS versions and on appveyor with all combinations of VS version/arch.

@mpeterv mpeterv merged commit db8e673 into luarocks:master Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants