Move common luarocks.fs.{unix,win32}.tools functions into a new module
#561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if I can trust the AppVeyor build as an indicator that nothing broke on Windows... :) |
|
@hishamhm I've tested this on Windows, a single install commands gave pretty good coverage for the changed modules, so it should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions in
luarocks.fs.{unix,win32}.toolshave same implementations. Some of them use different implementations of local platform specific helper functions. This PR creates exposes these functions and moves common functions into a newluarocks.fs.toolsmodule.