-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change binary lists in mysql mocks to base64 strings for readability #1276
Conversation
Apply Sweep Rules to your PR?
|
for { | ||
configMocks := h.GetConfigMocks() | ||
tcsMocks := h.GetTcsMocks() | ||
firstSQLMock := func(configMocks []*models.Mock) (*models.Mock, bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function can be defined outside and better be named as GetFirstMysqlMock
and I guess we should also compare the mock with some properties, instead of impetuously returning the first mock. Reason behind can be the case where fist mock written in the yaml itself is not the initial handshake mock .
Also make this field into base46 as well -
|
Also since we have implemented memDb for handling mvcc in the mock transactions, It's beneficiary to use the newly introduced method
|
Okay will make the changes once PR 1214 gets merged |
@Hermione2408 you can make the above changes as the PR has been merged for the deleteTCS mocks |
0f7ec9f
to
89282a9
Compare
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
…trings for readability change binary lists in mysql mocks to base64 strings for readability and add a function to filter out the firstSQL mock for handshake Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
* fix: runs the commands using the -c flag of sh the sh shell provides a flag to run multiple commands from a single shell cmd. So using this we will be able to use the parsing of script cmds of shell Signed-off-by: re-Tick <jain.ritik.1001@gmail.com> --------- Signed-off-by: re-Tick <jain.ritik.1001@gmail.com> Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
* fix: remove binary match Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: add in memoryDb in test mode Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: merge conflicts Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: add binary matching with benchmark Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: remove mongo changes Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: remove print statements Signed-off-by: charankamarapu <kamarapucharan@gmail.com> --------- Signed-off-by: charankamarapu <kamarapucharan@gmail.com> Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
… tags in MYSQL add omitempty,flow to json,yaml tags in MYSQL Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
* fix: remove binary match Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: add in memoryDb in test mode Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: merge conflicts Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: add binary matching with benchmark Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: remove mongo changes Signed-off-by: charankamarapu <kamarapucharan@gmail.com> * fix: remove print statements Signed-off-by: charankamarapu <kamarapucharan@gmail.com> --------- Signed-off-by: charankamarapu <kamarapucharan@gmail.com> Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com> Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com> Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
a9563f2
to
589ea7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)