Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Docker Installation Alias for linux #1492

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Updated Docker Installation Alias for linux #1492

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
496bf17
Updated Docker Installation Alias for linux
Akash-Singh04 Feb 4, 2024
c453cd5
Merge branch 'main' into dockeraliasupdate
Akash-Singh04 Feb 5, 2024
7cce16a
Merge branch 'main' into dockeraliasupdate
Akash-Singh04 Feb 5, 2024
486aa25
Merge branch 'main' into dockeraliasupdate
Akash-Singh04 Feb 6, 2024
0199043
Merge branch 'main' into dockeraliasupdate
Akash-Singh04 Feb 6, 2024
f420f7a
Added Docker group check
Akash-Singh04 Feb 6, 2024
82e5d26
Addressed Review Comment
Akash-Singh04 Feb 7, 2024
f091139
Merge branch 'main' into dockeraliasupdate
Akash-Singh04 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions keploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,25 @@ installKeploy (){
}

install_docker() {
if ! docker network ls | grep -q 'keploy-network'; then
docker network create keploy-network
fi
if ! docker network ls | grep -q 'keploy-network'; then
docker network create keploy-network
fi

if [ "$OS_NAME" = "Darwin" ]; then
if ! docker volume inspect debugfs &>/dev/null; then
docker volume create --driver local --opt type=debugfs --opt device=debugfs debugfs
fi
alias keploy='sudo docker run --pull always --name keploy-v2 -p 16789:16789 --privileged --pid=host -it -v $(pwd):$(pwd) -w $(pwd) -v /sys/fs/cgroup:/sys/fs/cgroup -v debugfs:/sys/kernel/debug:rw -v /sys/fs/bpf:/sys/fs/bpf -v /var/run/docker.sock:/var/run/docker.sock -v '"$HOME"'/.keploy-config:/root/.keploy-config -v '"$HOME"'/.keploy:/root/.keploy --rm ghcr.io/keploy/keploy'
if [ "$OS_NAME" = "Darwin" ]; then
if ! docker volume inspect debugfs &>/dev/null; then
docker volume create --driver local --opt type=debugfs --opt device=debugfs debugfs
fi
alias keploy='docker run --pull always --name keploy-v2 -p 16789:16789 --privileged --pid=host -it -v $(pwd):$(pwd) -w $(pwd) -v /sys/fs/cgroup:/sys/fs/cgroup -v debugfs:/sys/kernel/debug:rw -v /sys/fs/bpf:/sys/fs/bpf -v /var/run/docker.sock:/var/run/docker.sock -v '"$HOME"'/.keploy-config:/root/.keploy-config -v '"$HOME"'/.keploy:/root/.keploy --rm ghcr.io/keploy/keploy'
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use else if here, we are doing this specifically on linux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check if this was the intended change

if groups "$USER" | grep -q '\bdocker\b'; then
alias keploy='docker run --pull always --name keploy-v2 -p 16789:16789 --privileged --pid=host -it -v $(pwd):$(pwd) -w $(pwd) -v /sys/fs/cgroup:/sys/fs/cgroup -v /sys/kernel/debug:/sys/kernel/debug -v /sys/fs/bpf:/sys/fs/bpf -v /var/run/docker.sock:/var/run/docker.sock -v '"$HOME"'/.keploy-config:/root/.keploy-config -v '"$HOME"'/.keploy:/root/.keploy --rm ghcr.io/keploy/keploy'
else
alias keploy='sudo docker run --pull always --name keploy-v2 -p 16789:16789 --privileged --pid=host -it -v $(pwd):$(pwd) -w $(pwd) -v /sys/fs/cgroup:/sys/fs/cgroup -v /sys/kernel/debug:/sys/kernel/debug -v /sys/fs/bpf:/sys/fs/bpf -v /var/run/docker.sock:/var/run/docker.sock -v '"$HOME"'/.keploy-config:/root/.keploy-config -v '"$HOME"'/.keploy:/root/.keploy --rm ghcr.io/keploy/keploy'
fi
fi
}


}


ARCH=$(uname -m)
Expand Down
Loading