Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unittest for wrappednodefetch function #74

Closed
wants to merge 11 commits into from

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

Related Issue

Info about Issue or bug
Closes: keploy/keploy#354

added a unittest for wrappednodefetch function and added github actions

Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 26, 2023

Please follow this convention for commit messages.

Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 28, 2023

Hi @Sekhar-Kumar-Dash, can you close this PR and make other one with the correct commit convention. Because it is getting difficult to track your changes. Also the unit test logic is correct will have to run it whether it is working or not.

@Sekhar-Kumar-Dash
Copy link
Contributor Author

Related Issue

Info about Issue or bug Closes: keploy/keploy#354

added a unittest for wrappednodefetch function and added github actions

@re-Tick i raised a new pr please review it
#82

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash deleted the master branch March 29, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants