(node-fetch)-fixing #79
Conversation
VishalMyla
commented
Mar 26, 2023
VishalMyla
commented
- The outcome of running fetchFunc with the url and options arguments using the apply method should be returned by the wrappedFetch function.
- The apply method sends the url and options parameters as an array and sets the this keyword within the fetchFunc function to the value of this inside the wrappedFetch function. This guarantees that fetchFunc is called correctly and with the appropriate parameters, returning the serve answer.
|
LGTM. Please follow the commit convention to pass the ci action. Please add this PR link in GSOC task list. |
|
i think i got wrong at the commit part |
This commit fixes a bug that caused an empty response when making an HTTP call using the node-fetch library. The issue was caused by a failure to handle empty responses properly, which resulted in errors being thrown and incomplete data being returned. Signed-off-by: Vishal Myla <vishalmyla@gmail.com>
|
@re-Tick Please approve , I followed the commit convention to pass the ci action. |
|
LGTM. Please add the PR link in the GSOC/2023. The commit messages still have error. |
|
This is my commit message can you tell me where the error is occured , |
|
I think you should rebase your previous commit messages. And if you did that then, you have to push them to github again. |
|
I have cleared all the commit errors now . |
|
Are you using commitzen for conventional commits. Build is still failing due to commits. Can you close this PR and make PR from another git branch using commitzen for commits. |
