Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Misleading warning on Keptn CLI during keptn auth #4720

Closed
grabnerandi opened this issue Jul 21, 2021 · 7 comments
Closed

Misleading warning on Keptn CLI during keptn auth #4720

grabnerandi opened this issue Jul 21, 2021 · 7 comments
Assignees
Labels
area:cli good first issue Issues for getting started developing Keptn type:improvement Improves/enhances an existing feature
Milestone

Comments

@grabnerandi
Copy link
Member

This happens with keptn cli 0.8.6

When doing a Keptn auth the first output is a warning that keptn CLI is currently not authenticated. This is misleading and doesnt make sense when calling keptn auth as I am just about to authenticate

here a screenshot to show this warning
image

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2021
@thisthat thisthat added good first issue Issues for getting started developing Keptn type:improvement Improves/enhances an existing feature and removed stale labels Sep 20, 2021
@thisthat thisthat added this to Backlog in Working items via automation Sep 20, 2021
@nevosial
Copy link

nevosial commented Oct 4, 2021

Hello I would like to work on this .
Can you help me where to get started as I am a new contributor.

@warber
Copy link
Contributor

warber commented Oct 5, 2021

@nevosial thx for your desire to contribute.

The CLI code base is part of this mono repo.
Just grab a fork of this repo and start working on this on your own branch.

You can find more information about this here
You can use Visual Studio Code, Goland, or any other dev environment - It does not matter so much, especially as this is a CLI issue, hence it is rather easy to build and test it. Just compile it locally and issue commands to your keptn installation to try it out.

The relevant files to start taking a look at in order to fix this issue are cli/cmd/auth.go as well as cli/cmd/root.go. After a quick look, I would bet that the error message comes from this line which originates from the root command where it tries to make a version check when a command is executed....

hope this helps

@johannes-b johannes-b moved this from Backlog to Assigned and committed in Working items Nov 25, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@thisthat thisthat removed the stale label Jan 5, 2022
@madhavsikka
Copy link

madhavsikka commented Mar 10, 2022

Hi, can I take this up ? @thisthat

@thisthat
Copy link
Member

Hi, @madhavsikka! Thank you for your help, I'll assign this to you :D
I believe this was fixed while doing some refactoring of the CLI. Please, verify if this problem still occurs :)

@madhavsikka
Copy link

Yeah, I don't see this issue now. Thanks

@thisthat thisthat added this to the 0.14.0 milestone Mar 25, 2022
@johannes-b johannes-b moved this from Assigned and committed to Done/presented in community review (column will be cleaned regularly) in Working items Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:cli good first issue Issues for getting started developing Keptn type:improvement Improves/enhances an existing feature
Projects
No open projects
Working items
Done/presented in community review (c...
Development

No branches or pull requests

5 participants