Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Aborting a pending deployment sequence in helm-service leads to failure until the aborted sequence finally finishes #5557

Closed
christian-kreuzberger-dtx opened this issue Oct 7, 2021 · 2 comments
Assignees
Labels
area:helm-service Everything related to the helm-service area:shipyard-controller Issue is related to the shipyard-controller doc documentation type:bug Something is not working as intended/documented
Milestone

Comments

@christian-kreuzberger-dtx
Copy link
Member

christian-kreuzberger-dtx commented Oct 7, 2021

This is with Keptn 0.9.2.

Current behaviour

I am deploying podtato-head and accidentally tried to deploy an image with a tag that does not exist.
I noticed my mistake, and aborted the delivery sequence:
image

However, when I triggered the next delivery sequence, I ended up getting the following error message:

Error when installing/upgrading chart pod-tato-head-dev-helloservice in namespace pod-tato-head-dev: another operation (install/upgrade/rollback) is in progress

This is to be expected, as helm-service is still working (or in other words, helm-service has not finished and sent out a deployment.finished event).

Eventually helm-service has finished in the aborted sequence, and I can deploy again.

Expected behaviour

Either helm-service or shipyard-controller need to react on the aborted sequence.

  • When aborting, helm-service could abort the deployment process using helm cli and send out a deployment.finished event
  • When aborting, shipyard-controller could wait until helm-service sends the deployment.finished CloudEvent (or times out) before starting the next sequence
@christian-kreuzberger-dtx christian-kreuzberger-dtx added type:bug Something is not working as intended/documented area:shipyard-controller Issue is related to the shipyard-controller area:helm-service Everything related to the helm-service labels Oct 7, 2021
@johannes-b johannes-b added this to the 0.11.0 milestone Oct 11, 2021
@thisthat thisthat modified the milestones: 0.11.0, 0.10.0 Oct 12, 2021
@thisthat thisthat modified the milestones: 0.10.0, 0.11.0 Oct 21, 2021
@thisthat thisthat added doc documentation and removed needs discussion labels Nov 3, 2021
@thisthat
Copy link
Member

thisthat commented Nov 3, 2021

This ticket will be solved by adding this limitation to our documentation: Aborting a sequence does not aborts the running task

@bacherfl bacherfl self-assigned this Nov 8, 2021
@bacherfl
Copy link
Member

bacherfl commented Nov 8, 2021

It seems like this behavior was already documented: https://keptn.sh/docs/0.10.x/reference/bridge/manage_sequences/#aborting-sequences

@bacherfl bacherfl closed this as completed Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:helm-service Everything related to the helm-service area:shipyard-controller Issue is related to the shipyard-controller doc documentation type:bug Something is not working as intended/documented
Projects
None yet
Development

No branches or pull requests

4 participants