Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: Enable Nats queue groups in helm chart (#4519) #6062

Merged
merged 5 commits into from Nov 24, 2021
Merged

feat: Enable Nats queue groups in helm chart (#4519) #6062

merged 5 commits into from Nov 24, 2021

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 19, 2021 •
edited

Closes #4519

Integration test run: https://github.com/keptn/keptn/runs/4296832461?check_suite_focus=true
Note: The failed test on minishift seemed to be a temporary problem with minishift itself

@bacherfl
feat: Enable Nats queue groups in helm chart (#4519)
7798d3b 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021 •
edited

Codecov Report

Merging #6062 (d9d7513) into master (602eb37) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
- Coverage   56.86%   56.57%   -0.29%     
==========================================
  Files         416      416              
  Lines       24217    24113     -104     
  Branches     1403     1403              
==========================================
- Hits        13772    13643     -129     
- Misses       9473     9511      +38     
+ Partials      972      959      -13
Impacted Files Coverage Δ
distributor/pkg/lib/events/receiver.go 61.01% <0.00%> (-5.37%) ⬇️
shipyard-controller/main.go 5.55% <0.00%> (-0.06%) ⬇️
shipyard-controller/handler/sequence_migrator.go
...rd-controller/db/migration/project_mv_migration.go 52.63% <0.00%> (ø)
distributor/pkg/lib/events/utils.go 95.65% <0.00%> (+0.72%) ⬆️
shipyard-controller/db/mongodb_project_repo.go 3.39% <0.00%> (+1.82%) ⬆️
distributor/pkg/lib/controlplane/uniformlog.go 76.56% <0.00%> (+4.68%) ⬆️

@bacherfl
fix message filtering in distributor
ebd167c 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
fix overlapping subscriptions for queue groups
14fd3dc 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2021 •
edited

Docker Build Report

  • Pushed keptn/approval-service:0.10.1-dev-PR-6062.202111221259 and keptn/approval-service:0.10.1-dev-PR-6062 (Source: approval-service/)
  • Pushed keptn/distributor:0.10.1-dev-PR-6062.202111221259 and keptn/distributor:0.10.1-dev-PR-6062 (Source: distributor/)
  • Pushed keptn/jmeter-service:0.10.1-dev-PR-6062.202111221259 and keptn/jmeter-service:0.10.1-dev-PR-6062 (Source: jmeter-service/)
  • Pushed keptn/api:0.10.1-dev-PR-6062.202111221259 and keptn/api:0.10.1-dev-PR-6062 (Source: api/)
  • Pushed keptn/lighthouse-service:0.10.1-dev-PR-6062.202111221259 and keptn/lighthouse-service:0.10.1-dev-PR-6062 (Source: lighthouse-service/)
  • Pushed keptn/remediation-service:0.10.1-dev-PR-6062.202111221259 and keptn/remediation-service:0.10.1-dev-PR-6062 (Source: remediation-service/)
  • Pushed keptn/openshift-route-service:0.10.1-dev-PR-6062.202111221259 and keptn/openshift-route-service:0.10.1-dev-PR-6062 (Source: platform-support/openshift-route-service/)
  • Pushed keptn/configuration-service:0.10.1-dev-PR-6062.202111221259 and keptn/configuration-service:0.10.1-dev-PR-6062 (Source: configuration-service/)
  • Pushed keptn/helm-service:0.10.1-dev-PR-6062.202111221259 and keptn/helm-service:0.10.1-dev-PR-6062 (Source: helm-service/)
  • Pushed keptn/mongodb-datastore:0.10.1-dev-PR-6062.202111221259 and keptn/mongodb-datastore:0.10.1-dev-PR-6062 (Source: mongodb-datastore/)
  • Pushed keptn/webhook-service:0.10.1-dev-PR-6062.202111221259 and keptn/webhook-service:0.10.1-dev-PR-6062 (Source: webhook-service/)
  • Pushed keptn/statistics-service:0.10.1-dev-PR-6062.202111221259 and keptn/statistics-service:0.10.1-dev-PR-6062 (Source: statistics-service/)
  • Pushed keptn/secret-service:0.10.1-dev-PR-6062.202111221259 and keptn/secret-service:0.10.1-dev-PR-6062 (Source: secret-service/)
  • Pushed keptn/shipyard-controller:0.10.1-dev-PR-6062.202111221259 and keptn/shipyard-controller:0.10.1-dev-PR-6062 (Source: shipyard-controller/)
  • Pushed keptn/bridge2:0.10.1-dev-PR-6062.202111221259 and keptn/bridge2:0.10.1-dev-PR-6062 (Source: bridge/)

@bacherfl
updated integration tests
c5a419c 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl
Merge branch 'master' into feature/4519/nats-queuegroup
d9d7513 
# Conflicts:
#	distributor/pkg/lib/events/receiver_test.go
#	test/go-tests/uniform_test.go
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review November 23, 2021 07:43
@bacherfl bacherfl requested a review from a team as a code owner November 23, 2021 07:43
RealAnna
RealAnna approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacherfl bacherfl merged commit 9c493c7 into master Nov 24, 2021
@bacherfl bacherfl deleted the feature/4519/nats-queuegroup branch November 24, 2021 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Replicas: Process messages at most once
2 participants
@bacherfl @RealAnna