This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(shipyard-controller): Consider parallel stages when trying to set overall sequence state to finished #7250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overall sequence state to finished Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
bacherfl
added
the
CI:trigger-build-everything
bacherfl
requested review from
mowies,
christian-kreuzberger-dtx and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7250 +/- ##
=======================================
Coverage 58.56% 58.57%
=======================================
Files 528 528
Lines 30784 30790 +6
Branches 1508 1508
=======================================
+ Hits 18030 18034 +4
- Misses 11488 11490 +2
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Mar 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #7237
This PR fixes an issue where the overall state of a sequence was set to finished, even though the sequence might not have been finished in all stages. That error appears when there are parallel sequences executed in multiple stages, the completion of one of those sequences, whose completion should not trigger any further sequences leads to the overall state being set to finished
Integration test run: https://github.com/keptn/keptn/runs/5675950423?check_suite_focus=true
The failing test on GKE seems to be a known error with the BackupRestoreConfigurationService integration test that's currently under investigation