This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
feat(approval-service): Consider nats connection in readiness probe #7723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7723 +/- ##
=======================================
Coverage 60.00% 60.01%
=======================================
Files 558 558
Lines 31907 31907
Branches 1590 1590
=======================================
+ Hits 19147 19149 +2
+ Misses 11462 11460 -2
Partials 1298 1298
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
force-pushed
the
feat/7613/approval-svc-readiness
branch
from
b2dc8ff
to
6fa446c
Compare
bacherfl
added
the
CI:trigger-build-everything
odubajDT
reviewed
May 13, 2022
approval-service/go.mod
Outdated
| @@ -7,7 +7,7 @@ require ( | |||
| github.com/google/uuid v1.3.0 | |||
| github.com/kelseyhightower/envconfig v1.4.0 | |||
| github.com/keptn/go-utils v0.15.1-0.20220512082458-c5e1b7519bec | |||
| github.com/keptn/keptn/cp-connector v0.0.0-20220509104843-d040776782e2 | |||
| github.com/keptn/keptn/cp-connector v0.0.0-20220512103206-c36faf0071dc | |||
There was a problem hiding this comment.
pls update dependency to the newest
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
odubajDT
force-pushed
the
feat/7613/approval-svc-readiness
branch
from
7b410c0
to
99f07be
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
removed
the
CI:trigger-build-everything
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7613
This PR modifies the readiness probe of the approval service to consider the current state of the control plane connector. The service will now be considered ready, only when it's connected to the controlplane. Until that is the case, previous pods of the approval-service will not be terminated. This will ensure that there is always at least one replica available that is ready to receive events.
Integration test run: https://github.com/keptn/keptn/actions/runs/2313756860