Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Fixed missing 'View service details' button #7806

Merged
merged 13 commits into from Jun 2, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented May 19, 2022

Fixes #7803

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #7806 (6833b7b) into master (a87254a) will increase coverage by 0.15%.
The diff coverage is 86.88%.

@@            Coverage Diff             @@
##           master    #7806      +/-   ##
==========================================
+ Coverage   60.41%   60.56%   +0.15%     
==========================================
  Files         574      573       -1     
  Lines       33511    33459      -52     
  Branches     1690     1678      -12     
==========================================
+ Hits        20244    20263      +19     
+ Misses      11956    11887      -69     
+ Partials     1311     1309       -2     
Impacted Files Coverage Δ
bridge/client/app/_models/service.ts 55.00% <ø> (+5.00%) ⬆️
bridge/client/app/_services/api.service.mock.ts 70.46% <ø> (+1.63%) ⬆️
bridge/client/app/_services/api.service.ts 30.63% <0.00%> (-0.71%) ⬇️
bridge/server/api/index.ts 45.50% <ø> (ø)
bridge/server/services/data-service.ts 63.31% <0.00%> (-0.11%) ⬇️
bridge/client/app/_services/data.service.ts 69.37% <100.00%> (+2.01%) ⬆️
...ent/app/evaluation-board/evaluation-board-state.ts 100.00% <100.00%> (ø)
...p/evaluation-board/evaluation-board.component.html 100.00% <100.00%> (ø)
...app/evaluation-board/evaluation-board.component.ts 100.00% <100.00%> (+60.00%) ⬆️
bridge/server/services/api-service.ts 93.75% <100.00%> (+0.11%) ⬆️
... and 4 more
Flag Coverage Δ
bridge-server 67.64% <60.00%> (-0.01%) ⬇️
bridge2 75.94% <89.28%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@Kirdock Kirdock marked this pull request as ready for review May 25, 2022 07:03
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kirdock Kirdock merged commit 41cb52d into master Jun 2, 2022
@Kirdock Kirdock deleted the fix/7803/fix-visit-service-details-button branch June 2, 2022 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge: Missing "View service details" button in evaluation board
2 participants