Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(bridge): Trigger sequence - Remove polling for custom sequences #7813

Conversation

renepanzar
Copy link
Contributor

This PR

  • Removes polling from component
  • Removes dependency on POLLING_INTERVAL_MILLIS

Related Issues

Resolves #7797

How to test

  1. Go to project and trigger a new sequence
  2. Watch DevTools/Network panel for additional requests to /api/project/dockshop/customSequences (should be only a single request over time)

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #7813 (7a71e05) into master (b252b6d) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 7a71e05 differs from pull request most recent head 75a5e03. Consider uploading reports for the commit 75a5e03 to get more accurate results

@@            Coverage Diff             @@
##           master    #7813      +/-   ##
==========================================
- Coverage   60.34%   60.28%   -0.07%     
==========================================
  Files         571      571              
  Lines       33408    33430      +22     
  Branches     1670     1670              
==========================================
- Hits        20159    20152       -7     
- Misses      11940    11968      +28     
- Partials     1309     1310       +1     
Impacted Files Coverage Δ
lighthouse-service/event_handler/common.go 56.12% <0.00%> (-13.75%) ⬇️
distributor/pkg/uniform/log/uniformlog.go 71.87% <0.00%> (-4.69%) ⬇️
cli/cmd/trigger_sequence.go 67.67% <0.00%> (-1.48%) ⬇️
bridge/client/app/_services/api.service.ts 28.57% <0.00%> (-1.39%) ⬇️
...ttings-list/ktb-service-settings-list.component.ts 100.00% <0.00%> (ø)
...project-settings/ktb-project-settings.component.ts 81.25% <0.00%> (+0.52%) ⬆️
...b-evaluation-info/ktb-evaluation-info.component.ts 83.13% <0.00%> (+2.05%) ⬆️
Flag Coverage Δ
api 88.35% <0.00%> (ø)
approval-service 64.61% <0.00%> (ø)
bridge-server 67.62% <0.00%> (ø)
bridge2 74.95% <0.00%> (+0.03%) ⬆️
cli 43.04% <0.00%> (-0.01%) ⬇️
configuration-service 9.17% <0.00%> (ø)
distributor 67.98% <0.00%> (-0.31%) ⬇️
helm-service 49.07% <0.00%> (ø)
jmeter-service 25.29% <0.00%> (ø)
lighthouse-service 72.95% <0.00%> (-2.13%) ⬇️
mongodb-datastore 58.39% <0.00%> (ø)
remediation-service 79.77% <0.00%> (ø)
resource-service 81.37% <0.00%> (ø)
secret-service 81.47% <0.00%> (ø)
shipyard-controller 60.91% <0.00%> (ø)
statistics-service 59.29% <0.00%> (ø)
webhook-service 83.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@renepanzar renepanzar force-pushed the feat/7797/bridge-trigger-sequence---remove-polling-for-custom-sequences branch from d290ac3 to e2380d8 Compare May 25, 2022 06:35
@renepanzar
Copy link
Contributor Author

renepanzar commented May 25, 2022

Rebased on master with conflict resolution.

Kirdock
Kirdock previously approved these changes May 30, 2022
@renepanzar renepanzar force-pushed the feat/7797/bridge-trigger-sequence---remove-polling-for-custom-sequences branch from e2380d8 to 75a5e03 Compare May 30, 2022 13:18
- Removes polling from component
- Removes dependency on POLLING_INTERVAL_MILLIS

Signed-off-by: René Panzar <rene.panzar@dynatrace.com>
@renepanzar renepanzar force-pushed the feat/7797/bridge-trigger-sequence---remove-polling-for-custom-sequences branch from 75a5e03 to a590a2e Compare May 31, 2022 08:37
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@renepanzar renepanzar merged commit 138a773 into master May 31, 2022
@mowies mowies deleted the feat/7797/bridge-trigger-sequence---remove-polling-for-custom-sequences branch September 27, 2022 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge :: Trigger sequence - Remove polling for custom sequences
3 participants