Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(shipyard-controller): Allow parallel sequence execution if the service is different #7825

Merged
merged 7 commits into from May 23, 2022

Conversation

RealAnna
Copy link
Contributor

backport of #7775

…rvice is different

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna RealAnna requested a review from a team as a code owner May 23, 2022 07:37
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but let's wait for the unit tests :)

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #7825 (ef5ce6a) into 0.15.x (9e0e7cf) will increase coverage by 0.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           0.15.x    #7825      +/-   ##
==========================================
+ Coverage   59.96%   59.97%   +0.01%     
==========================================
  Files         561      561              
  Lines       31980    31989       +9     
  Branches     1601     1601              
==========================================
+ Hits        19178    19187       +9     
  Misses      11495    11495              
  Partials     1307     1307              
Impacted Files Coverage Δ
shipyard-controller/handler/eventdispatcher.go 58.02% <92.30%> (+2.18%) ⬆️
shipyard-controller/handler/sequencedispatcher.go 71.77% <100.00%> (+0.22%) ⬆️
Flag Coverage Δ
shipyard-controller 60.92% <92.85%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna merged commit f6bb098 into 0.15.x May 23, 2022
@RealAnna RealAnna deleted the fix/add_parallel_service_sequences branch May 23, 2022 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants