This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(webhook-service): Added missing webhook-config version check #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odubajDT
added
the
CI:trigger-build-everything
Codecov Report
@@ Coverage Diff @@
## master #7832 +/- ##
==========================================
+ Coverage 60.07% 60.09% +0.02%
==========================================
Files 569 569
Lines 33351 33363 +12
Branches 1655 1655
==========================================
+ Hits 20035 20051 +16
+ Misses 12006 12003 -3
+ Partials 1310 1309 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
removed
the
CI:trigger-build-everything
odubajDT
added
the
CI:trigger-build-everything
odubajDT
changed the title
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
mowies
approved these changes
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com
Notes
When retrieving resources from git repository, the first step is decoding the content of webhook.yaml to a struct. Here we have two versions (alpha and beta) which are mostly normalized the same way except beta has a few additional checks. These checks were executed only if the version of the webhook-config was v1beta1, if it was different, additional checks were not executed. So actually the in the integration test, we had a valid webhook-config, so if the extra pre-check is or is not executed, it does not matter, the webhook is executed normally (and it's working), just the extra pre-checks were not executed.
Integration tests
https://github.com/keptn/keptn/actions/runs/2372897926