Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Fix missing evaluation score of sequence #8032

Merged
merged 2 commits into from Jun 8, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Jun 8, 2022

Fixes #8031

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
ermin-muratovic
ermin-muratovic previously approved these changes Jun 8, 2022
Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #8032 (bbca7ec) into master (592d97f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8032   +/-   ##
=======================================
  Coverage   60.59%   60.59%           
=======================================
  Files         573      573           
  Lines       33446    33446           
  Branches     1669     1669           
=======================================
  Hits        20267    20267           
  Misses      11869    11869           
  Partials     1310     1310           
Impacted Files Coverage Δ
bridge/server/services/api-service.ts 93.75% <100.00%> (ø)
Flag Coverage Δ
bridge-server 67.56% <100.00%> (ø)
bridge2 75.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kirdock Kirdock merged commit 3fe27e0 into master Jun 8, 2022
@Kirdock Kirdock deleted the fix/8031/fix-sequence-evaluation-score branch June 8, 2022 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge: Missing evaluation score for sequence
2 participants