Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(bridge): Refactor dashboard to use interfaces #8205

Merged
merged 5 commits into from Jun 28, 2022

Conversation

heinzburgstaller
Copy link
Contributor

@heinzburgstaller heinzburgstaller commented Jun 27, 2022

This PR

  • Add IProject, IProjectResult, ISequence
  • Refactor components and services

Related Issues

Adds to #8023

Notes

This is phase 2 of the refactoring plan:
IMG_20220622_163331

Signed-off-by: Heinz Burgstaller heinz.burgstaller@dynatrace.com

- Add IProject, IProjectResult
- Refactor components and services

Signed-off-by: Heinz Burgstaller <heinz.burgstaller@dynatrace.com>
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #8205 (548eaee) into master (a0d6768) will increase coverage by 0.06%.
The diff coverage is 95.93%.

❗ Current head 548eaee differs from pull request most recent head 876bd2e. Consider uploading reports for the commit 876bd2e to get more accurate results

@@            Coverage Diff             @@
##           master    #8205      +/-   ##
==========================================
+ Coverage   62.80%   62.87%   +0.06%     
==========================================
  Files         626      625       -1     
  Lines       33333    33392      +59     
  Branches     1640     1657      +17     
==========================================
+ Hits        20935    20995      +60     
+ Misses      11103    11102       -1     
  Partials     1295     1295              
Impacted Files Coverage Δ
...s/ktb-project-list/ktb-project-tile.component.html 100.00% <ø> (ø)
...-state-info/ktb-sequence-state-info.component.html 100.00% <ø> (ø)
...-state-list/ktb-sequence-state-list.component.html 100.00% <ø> (ø)
bridge/server/models/remediation.ts 100.00% <ø> (ø)
bridge/server/models/sequence.ts 100.00% <ø> (ø)
bridge/server/services/data-service.ts 61.81% <ø> (ø)
bridge/shared/interfaces/sequence.ts 100.00% <ø> (ø)
...ce-state-list/ktb-sequence-state-list.component.ts 73.91% <55.55%> (-7.91%) ⬇️
bridge/client/app/_models/project.ts 69.23% <94.73%> (+7.98%) ⬆️
...nts/ktb-project-list/ktb-project-list.component.ts 100.00% <100.00%> (ø)
... and 17 more
Flag Coverage Δ
bridge-server 68.25% <100.00%> (+0.03%) ⬆️
bridge2 79.23% <95.76%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Heinz Burgstaller <heinz.burgstaller@dynatrace.com>
Signed-off-by: Heinz Burgstaller <heinz.burgstaller@dynatrace.com>
Signed-off-by: Heinz Burgstaller <heinz.burgstaller@dynatrace.com>
Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@heinzburgstaller heinzburgstaller merged commit 2cbbc2d into master Jun 28, 2022
@heinzburgstaller heinzburgstaller deleted the feat/8023/interfaces-in-dashboard branch June 28, 2022 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants