Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(installer): Revert immutable k8s labels #8213

Merged
merged 28 commits into from Jun 29, 2022
Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Jun 27, 2022

This PR

  • reverts some changes from feat(installer): Helm Chart revamp #7678 since they broke the keptn installation
  • renames all helper functions to be prefixed with keptn.* to prevent naming collisions with bitnami's common chart which is used in mongodb
  • speeds up the ZD test pipeline slightly by only installing the node dependencies if the cypress tests are run alongside the go tests

Fixes #8209
Integration test run: https://github.com/keptn/keptn/actions/runs/2581393075

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #8213 (0ef7903) into master (3ee5d1b) will increase coverage by 0.00%.
The diff coverage is 16.66%.

@@           Coverage Diff           @@
##           master    #8213   +/-   ##
=======================================
  Coverage   62.93%   62.94%           
=======================================
  Files         628      628           
  Lines       33647    33647           
  Branches     1658     1658           
=======================================
+ Hits        21176    21179    +3     
+ Misses      11172    11169    -3     
  Partials     1299     1299           
Impacted Files Coverage Δ
distributor/pkg/config/envconfig.go 54.88% <0.00%> (ø)
mongodb-datastore/handlers/events.go 0.00% <0.00%> (ø)
...stributor/pkg/uniform/controlplane/controlplane.go 97.64% <100.00%> (ø)
cli/pkg/config/cli_config.go 59.75% <0.00%> (+3.65%) ⬆️
Flag Coverage Δ
approval-service 64.61% <ø> (ø)
distributor 69.88% <20.00%> (ø)
helm-service 47.57% <ø> (ø)
jmeter-service 25.29% <ø> (ø)
lighthouse-service 75.07% <ø> (ø)
mongodb-datastore 57.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies added CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE and removed CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE labels Jun 28, 2022
@mowies mowies force-pushed the fix/8209/fix-labels branch 2 times, most recently from d34c586 to d12dfea Compare June 28, 2022 11:55
mowies added 16 commits June 28, 2022 16:16
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
…staller

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
RealAnna and others added 6 commits June 28, 2022 16:35
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
…ture

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review June 29, 2022 11:07
@mowies mowies removed the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jun 29, 2022
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@mowies mowies changed the title fix(installer): Revert immutable labels fix(installer): Revert immutable k8s labels Jun 29, 2022
@mowies mowies merged commit bed7b04 into master Jun 29, 2022
@mowies mowies deleted the fix/8209/fix-labels branch June 29, 2022 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keptn upgrade broken because of change to selectorLabels
2 participants