Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Settings view overflow problem #8291

Merged
merged 1 commit into from Jul 5, 2022

Conversation

TannerGilbert
Copy link
Member

This PR

  • Fixes problem where a code block would be bigger than the screen (move outside the screen)

Related Issues

Fixes #8278

Notes

ffFlex change for dt-menu is now identical to other dt-menu inside project-board.component.html

<div fxFlex="calc(100%-50px)">
<router-outlet></router-outlet>
</div>

4k:
overflow-fix-4k

1080p:
overflow-fix-1080p

Additionally the resizing of the settings-view improved in general:

Before:
resizing-before

Now:
resizing-after

Signed-off-by: TannerGilbert gilberttanner.work@gmail.com

Signed-off-by: TannerGilbert <gilberttanner.work@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #8291 (228894a) into master (7a17271) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8291   +/-   ##
=======================================
  Coverage   63.03%   63.03%           
=======================================
  Files         628      628           
  Lines       33636    33636           
  Branches     1689     1689           
=======================================
  Hits        21201    21201           
  Misses      11134    11134           
  Partials     1301     1301           
Impacted Files Coverage Δ
...ktb-settings-view/ktb-settings-view.component.html 100.00% <ø> (ø)
Flag Coverage Δ
bridge-server 73.65% <ø> (ø)
bridge2 78.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@TannerGilbert TannerGilbert merged commit f473eb6 into master Jul 5, 2022
@TannerGilbert TannerGilbert deleted the fix/8278/code-page-overflow branch July 12, 2022 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge: Code overflowing parent element
2 participants