Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(installer): Security Improvements #8373

Merged
merged 8 commits into from Jul 13, 2022
Merged

feat(installer): Security Improvements #8373

merged 8 commits into from Jul 13, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Jul 11, 2022

This PR

  • adds some basic security adjustments for the helm chart

Integration test run: https://github.com/keptn/keptn/actions/runs/2661339140

@mowies mowies added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #8373 (a942178) into master (bac5984) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8373      +/-   ##
==========================================
- Coverage   66.44%   66.43%   -0.01%     
==========================================
  Files         612      612              
  Lines       31897    31897              
  Branches     1677     1677              
==========================================
- Hits        21195    21192       -3     
- Misses       9410     9412       +2     
- Partials     1292     1293       +1     
Impacted Files Coverage Δ
distributor/pkg/uniform/log/uniformlog.go 71.87% <0.00%> (-4.69%) ⬇️
Flag Coverage Δ
api 88.56% <ø> (ø)
approval-service 64.61% <ø> (ø)
bridge-server 73.77% <ø> (ø)
bridge2 78.61% <ø> (ø)
cli 43.96% <ø> (ø)
distributor 69.88% <ø> (-0.30%) ⬇️
helm-service 47.57% <ø> (ø)
jmeter-service 25.29% <ø> (ø)
lighthouse-service 75.07% <ø> (ø)
mongodb-datastore 57.94% <ø> (ø)
remediation-service 100.00% <ø> (ø)
resource-service 81.46% <ø> (ø)
secret-service 81.47% <ø> (ø)
shipyard-controller 65.74% <ø> (ø)
statistics-service 58.41% <ø> (ø)
webhook-service 83.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies force-pushed the security-fixes branch 4 times, most recently from 35289a6 to 0abff85 Compare July 12, 2022 09:10
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies changed the title feat(installer): Security Adjustments feat(installer): Security Improvements Jul 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies marked this pull request as ready for review July 13, 2022 06:11
@mowies mowies requested a review from a team as a code owner July 13, 2022 06:11
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mowies mowies merged commit d946f67 into master Jul 13, 2022
@mowies mowies deleted the security-fixes branch July 13, 2022 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants