Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(cli): Print ID of Keptn context after sending events #8392

Merged
merged 4 commits into from Jul 12, 2022

Conversation

bacherfl
Copy link
Member

Closes #8391
Closes #8377

Previously the CLI relied on the SendEvent method of the go-utils to print the ID of the resulting Keptn context - this has - rightfully - been removed from the go-utils recently, so now the CLI is responsible to print the expected output itself - as it should be

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #8392 (1cec9ad) into master (e2837bb) will increase coverage by 0.00%.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##           master    #8392   +/-   ##
=======================================
  Coverage   66.40%   66.41%           
=======================================
  Files         612      612           
  Lines       31881    31887    +6     
  Branches     1688     1688           
=======================================
+ Hits        21172    21177    +5     
- Misses       9416     9418    +2     
+ Partials     1293     1292    -1     
Impacted Files Coverage Δ
cli/cmd/send_event.go 40.00% <0.00%> (-1.87%) ⬇️
cli/cmd/trigger_evaluation.go 61.68% <0.00%> (-1.18%) ⬇️
cli/cmd/trigger_delivery.go 64.61% <100.00%> (+0.55%) ⬆️
bridge/shared/models/trace.ts 69.71% <0.00%> (ø)
bridge/shared/fixtures/traces-response.mock.ts 100.00% <0.00%> (ø)
bridge/shared/fixtures/project-response.mock.ts 100.00% <0.00%> (ø)
...ridge/client/app/_services/_mockData/trace.mock.ts 100.00% <0.00%> (ø)
...client/app/_services/_mockData/deployments.mock.ts 100.00% <0.00%> (ø)
...client/app/_services/_mockData/evaluations.mock.ts 100.00% <0.00%> (ø)
...shared/fixtures/open-remediations-response.mock.ts 100.00% <0.00%> (ø)
... and 9 more
Flag Coverage Δ
api 88.19% <ø> (ø)
approval-service 64.61% <ø> (ø)
bridge-server 73.82% <ø> (ø)
bridge2 78.48% <ø> (ø)
cli 44.03% <28.57%> (-0.02%) ⬇️
distributor 70.17% <ø> (+0.29%) ⬆️
helm-service 47.57% <ø> (ø)
jmeter-service 25.29% <ø> (ø)
lighthouse-service 75.07% <ø> (ø)
mongodb-datastore 57.94% <ø> (ø)
remediation-service 100.00% <ø> (ø)
resource-service 81.46% <ø> (ø)
secret-service 81.47% <ø> (ø)
shipyard-controller 65.74% <ø> (ø)
statistics-service 58.41% <ø> (ø)
webhook-service 83.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review July 12, 2022 09:05
@bacherfl bacherfl requested a review from a team as a code owner July 12, 2022 09:05
@bacherfl bacherfl merged commit 65ce578 into master Jul 12, 2022
@bacherfl bacherfl deleted the fix/8391/fix-cli-output branch July 12, 2022 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
2 participants