Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore(bridge): Remove resource service feature flag #8635

Merged
merged 1 commit into from Aug 12, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Aug 11, 2022

Closes #8433

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #8635 (c67c661) into master (ee2a653) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8635      +/-   ##
==========================================
- Coverage   70.21%   70.21%   -0.01%     
==========================================
  Files         614      614              
  Lines       31294    31278      -16     
  Branches     1702     1702              
==========================================
- Hits        21973    21961      -12     
+ Misses       8109     8105       -4     
  Partials     1212     1212              
Impacted Files Coverage Δ
bridge/client/app/_models/server-error.ts 100.00% <ø> (ø)
...mockData/api-responses/bridgeInfo-response.mock.ts 100.00% <ø> (ø)
...views/ktb-error-view/ktb-error-view.component.html 100.00% <ø> (ø)
...oject-settings/ktb-project-settings.component.html 100.00% <ø> (ø)
bridge/server/feature-flags.ts 100.00% <ø> (ø)
bridge/client/app/_utils/test.utils.ts 75.00% <100.00%> (-4.04%) ⬇️
...project-settings/ktb-project-settings.component.ts 97.43% <100.00%> (+2.43%) ⬆️
Flag Coverage Δ
bridge-server 73.76% <ø> (-0.02%) ⬇️
bridge2 84.47% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@heinzburgstaller heinzburgstaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file keptn/bridge/deploy/service.yaml is the flag RESOURCE_SERVICE_ENABLED still there. Can also be deleted?

@Kirdock
Copy link
Contributor Author

Kirdock commented Aug 12, 2022

@heinzburgstaller This file is deprecated and does not even work. With #8571 we wanted to delete it anyway

@Kirdock Kirdock merged commit aeec940 into master Aug 12, 2022
@Kirdock Kirdock deleted the chore/8433/remove-resource-service-feature-flag branch August 12, 2022 06:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge :: Remove FF RESOURCE_SERVICE_ENABLED
2 participants