Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(webhook-service): Added unmarshalling of curl responses #8782

Merged
merged 4 commits into from Aug 31, 2022

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Aug 31, 2022

For each response, webhook attempts to convert it into an object and appends it to the finished event
image

closes #8256

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #8782 (c130e15) into master (2dd5e23) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c130e15 differs from pull request most recent head a0d1edb. Consider uploading reports for the commit a0d1edb to get more accurate results

@@            Coverage Diff             @@
##           master    #8782      +/-   ##
==========================================
+ Coverage   70.22%   70.23%   +0.01%     
==========================================
  Files         620      620              
  Lines       32556    32571      +15     
  Branches     1719     1719              
==========================================
+ Hits        22861    22876      +15     
  Misses       8481     8481              
  Partials     1214     1214              
Impacted Files Coverage Δ
webhook-service/handler/handler.go 88.57% <100.00%> (+0.64%) ⬆️
Flag Coverage Δ
webhook-service 84.13% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna RealAnna marked this pull request as ready for review August 31, 2022 11:08
@RealAnna RealAnna requested a review from a team as a code owner August 31, 2022 11:08
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit db8778e into master Aug 31, 2022
@mowies mowies deleted the feat/8256/webhook_response_as_json branch December 12, 2022 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webhook-service: Add response as JSON object if content-type is application/json
2 participants