Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(shipyard-controller): Adapt mongodb query to be compatible with DocumentDB #8977

Merged
merged 3 commits into from Oct 10, 2022

Conversation

bacherfl
Copy link
Member

In DocumentDB, queries containing both $ and $[<identifier>] selectors are not supported. This PR changes the query to update a service within a project accordingly

…ocumentDB

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #8977 (2994984) into 0.19.x (1abd798) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           0.19.x    #8977   +/-   ##
=======================================
  Coverage   70.31%   70.32%           
=======================================
  Files         622      622           
  Lines       32860    32911   +51     
  Branches     1724     1724           
=======================================
+ Hits        23106    23145   +39     
- Misses       8520     8528    +8     
- Partials     1234     1238    +4     
Impacted Files Coverage Δ
...ller/internal/db/models/projects_mv/projects_mv.go 84.84% <100.00%> (ø)
...ard-controller/internal/db/mongodb_project_repo.go 46.11% <100.00%> (ø)
...yard-controller/internal/handler/projectmanager.go 79.88% <0.00%> (-0.36%) ⬇️
Flag Coverage Δ
shipyard-controller 67.82% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review October 10, 2022 08:23
@bacherfl bacherfl requested a review from a team as a code owner October 10, 2022 08:23
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat
Copy link
Member

there are some test failings, otherwise LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants