Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(cli): display incompatible upgrade possibilities even if no minor upgrade is available #9381

Merged
merged 4 commits into from Dec 28, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Dec 28, 2022

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

Fixes: #9380

… upgrade possibility is available

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT requested a review from a team as a code owner December 28, 2022 07:51
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #9381 (5938820) into master (af30c51) will increase coverage by 0.06%.
The diff coverage is 95.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9381      +/-   ##
==========================================
+ Coverage   70.59%   70.66%   +0.06%     
==========================================
  Files         619      619              
  Lines       33013    33016       +3     
  Branches     1642     1642              
==========================================
+ Hits        23305    23330      +25     
+ Misses       8461     8438      -23     
- Partials     1247     1248       +1     
Impacted Files Coverage Δ
cli/pkg/version/version_checker.go 71.73% <95.00%> (+14.70%) ⬆️
cli/cmd/version.go 63.47% <0.00%> (+2.60%) ⬆️
Flag Coverage Δ
cli 44.59% <95.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT changed the title fix(cli): display incompatible upgrade possibilities even if no minor upgrade possibility is available fix(cli): display incompatible upgrade possibilities even if no minor upgrade is available Dec 28, 2022
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 7d66999 into master Dec 28, 2022
@github-actions github-actions bot mentioned this pull request Dec 28, 2022
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI Version check doesn't work in a few CLI versions
2 participants